Replace requested_handshakes set with a callback #2469
Merged
+72
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues with bounding the map, and allows us to schedule handshakes immediately. We avoid a building herd of re-requested handshakes by rescheduling a handshake by handshake period just after our attempt to handshake.
Mark-Simulacrum
force-pushed
the
immediate-handshake
branch
from
2645b68 to
bd8e1bb
Compare
camshaft
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
n/a
Resolved issues:
n/a
Description of changes:
This drops the requested handshakes map in favor of supporting registering a callback. I initially tried/considered doing this as a Subscriber, but it gets pretty tricky to integrate that -- the Map is already getting passed into s2n-quic endpoints as a dc::Endpoint. Plus, the detailed logic on how to handshake interacts with application layer concerns (e.g., possibly throttling) that I'm not sure should live in s2n-quic.
Call-outs:
n/a
Testing:
No additional tests here - this sort of implies we have no tests for this functionality in s2n-quic-dc, which makes sense since that doesn't have any actual s2n-quic dependency. I'm not sure whether we should add one or otherwise tweak things in that regard. It should get caught in the internal integration tests. (Note that this is not safe by itself, all users of s2n-quic-dc need to add the registration to client handshake endpoints).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.