feat(s2n-quic-dc): Periodically re-handshake existing path secrets #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correctness property referenced in the removed comment is/will be moved into s2n-quic itself via deduplicate flag on the connection attempts. Our goal is to ensure that the path secret in `peers` is the most recent path secret from the perspective of both the initiator (client) and acceptor (server) side. If handshakes to the same peer could overlap, then the server may see secrets from the same peer appear in a different order than the client. That situation would eventually lead to us being more likely to remove the wrong secret, since we incorrectly think it's been replaced.
This avoids evicting state, but peers should be periodically re-handshaked to rotate the symmetric keys. We will request a handshakes starting at a random time and until there is a newer secret inserted, we will keep requesting a handshake roughly every minute (how often our background cleaning thread runs).
camshaft
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ongoing_handshakesstorage, since we no longer expect to use it. This is just drive-by cleanup.Map, which will ease providing knobs for customer-dependent usage.Testing:
Unfortunately, essentially none yet. I suspect that we'll want to have a long-lived canary of some kind that observes handshakes rates, etc. in practice as our highest fidelity test. Periodic, randomized functionality is otherwise pretty annoying to test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.