feat(wireshark-dcquic): add wireshark plugin #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
dc-quic-wireshark
branch
10 times, most recently
from
0dffb1d
to
483f851
Compare
camshaft
force-pushed
the
dc-quic-wireshark
branch
from
483f851
to
d4d77d7
Compare
camshaft
force-pushed
the
dc-quic-wireshark
branch
from
9a095c2
to
2a1f7dd
Compare
camshaft
force-pushed
the
dc-quic-wireshark
branch
from
6857a7d
to
60b74ab
Compare
|
|
||
| #[cfg(not(test))] | ||
| #[path = "full.rs"] | ||
| mod sys_impl; |
There was a problem hiding this comment.
Can we add a comment about the difference between minimal vs. full? Or maybe in generate-bindings.rs? It's not entirely clear to me why cfg(test) lets us pull in a subset of this, I'd expect tests to not bring in any externs (at least I think I had that working)
There was a problem hiding this comment.
Yeah I can add a comment.
I was still seeing linker errors on macos, even with the flags, but maybe that went away with other changes? Let me see.
There was a problem hiding this comment.
Ah nope. I get linker errors when running cargo bolero test as well.
Mark-Simulacrum
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a wireshark for debugging s2n-quic-dc traffic.
Testing:
The
dc-wiresharkjobs were added to theciworkflow to show it building/properly linking againstlibwireshark. This is done for both macos and linux.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.