Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic): expose configuration options for congestion control #2228

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented May 31, 2024

Description of changes:

This PR exposes a few configuration options that modify the default congestion controllers.

While it is possible to create a custom congestion controller, customers might find it more useful to simply override some key parameters on the deafult congestion controller algorithm rather than replicating the entire congestion control algorithm.

Call out:

  • The with_congestion_window API is exposed as a stable API, while other options are marked as unstable
    • While it makes sense to expose CC configuration parameters behind an unstable flag (getting them wrong can render the network impaired), setting the initial congestion window (initcwnd) is also supported on TCP and seems like a common enough use case.

Testing:

The new options should not affect the default values and therefore existing tests should continue to pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu changed the title Ak initcwnd feat(s2n-quic): expose configuration options for congestion control May 31, 2024
@toidiu toidiu force-pushed the ak-initcwnd branch 3 times, most recently from e8eae14 to 15f5f0a Compare June 3, 2024 01:25
@toidiu toidiu marked this pull request as ready for review June 3, 2024 02:50
quic/s2n-quic-core/src/recovery/cubic/tests.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/cubic.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/cubic.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/cubic.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/cubic.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved
quic/s2n-quic-core/src/recovery/bbr.rs Outdated Show resolved Hide resolved

#[cfg(feature = "unstable-congestion-controller")]
/// The dynamic gain factor used to scale the estimated BDP to produce a
/// congestion window (default: 2).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting the default values!

quic/s2n-quic-core/src/recovery/cubic.rs Outdated Show resolved Hide resolved
@toidiu toidiu merged commit 79e5d8e into main Jun 6, 2024
128 checks passed
@toidiu toidiu deleted the ak-initcwnd branch June 6, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants