Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-rustls): update rustls from 0.21 to 0.23 #2200

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented May 6, 2024

This PR reverts the revert PR to upgrade rustls:

Description of changes:

One noteworthy change: rustls now has a concept of crypto providers (ring or aws-lc-rs) and by default uses aws-lc-rs. For this reason I choose to use aws-lc-rs also, which is a change in behavior since previously we used ring. In the future we could expose the option for s2n-quic customers to choose their own crypto provider.

Call-outs:

I removed some deprecated exports because either:

  • they no longer exist (::rustls::{Certificate, PrivateKey})
  • they are not useful (pub static DEFAULT_CIPHERSUITES: &[rustls::SupportedCipherSuite])

Testing:

Existing unit tests and examples pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu changed the title Revert "Revert "feat(s2n-quic-rustls): update rustls from 0.21 to 0.2… feat(s2n-quic-rustls): update rustls from 0.21 to 0.23 May 6, 2024
@toidiu toidiu marked this pull request as ready for review May 7, 2024 01:08
@thynson
Copy link

thynson commented May 7, 2024

Since shipping this should be a breaking change, I think it can go a bit further that we should respect the CryptoProvider::get_default(), since it relying on the end user to do the initialization work, i.e. aws_lc_rs::default_provider().install_default(), which will be another breaking change.

@toidiu toidiu merged commit bd37960 into main May 9, 2024
129 checks passed
@toidiu toidiu deleted the ak-updateRustls branch May 9, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants