Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-provider): make some message methods public #2189

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

dignifiedquire
Copy link
Contributor

The need is described in #2188.

This is the minimal change I needed to implement my own custom io provider.

Resolved issues:

resolves #2188

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@goatgoose goatgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good. However, please note that the s2n-quic-platform crate is pre-1.0, so these APIs may break in a future release.

@dignifiedquire
Copy link
Contributor Author

dignifiedquire commented Apr 23, 2024

However, please note that the s2n-quic-platform crate is pre-1.0, so these APIs may break in a future release.

That's totally fine :) I am happy to update my code if it means I get to use pluggable providers

@camshaft camshaft merged commit fed54a5 into aws:main Apr 23, 2024
115 of 116 checks passed
@dignifiedquire dignifiedquire deleted the feat-provider-methods branch April 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: expose more s2n_quic_provider::message APIs
3 participants