refactor: rename mtu to max_datagram_size #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change renames some usages of the term
MTUtomax_datagram_sizeto better reflect what the value represents.MTUis usually used for referring to the maximum size of an IP packet that can be transmitted on a path, which includes the size of the IP headers and UDP headers that prefix a QUIC packet. In QUIC we are more concerned with the maximum size of a QUIC datagram that can be sent on a path. This "max datagram size" value does not include the size of IP headers and UDP headers.Call-outs:
I added a comment on the
mtufield of theMtuUpdatedevent indicating the value does not include IP header or UDP header sizes, but I did not mark the field as deprecated and add a new field, as it didn't seem worth it.Testing:
Existing tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.