ci: update quic-interop-runner pinned commit #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
docker compose v1 was removed from GitHub actions images: actions/runner-images#9557, causing our interop CI to fail
quic-interop-runner uses it, but they have updated to v2 upstream (quic-interop/quic-interop-runner#333)
This change updates the quic-interop-runner version we are using to the latest commit
Call-outs:
I added support for Rustls to parse SEC1-encoded EC keys, which is what Openssl outputs and is used in the interop runner as of quic-interop/quic-interop-runner#373
I've added back in
msquicto our local interop runner as it seems to not be failing as much lately. We can keep an eye on it and decide if it should be required to succeed.A couple bugs have been fixed in open PRs upstream:
quic-interop/quic-interop-runner#376
quic-interop/quic-interop-runner#380
I've included the fixes in our patch, once they are merged we can update again and reduce the patch size a bit
Testing:
Patch applies locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.