Skip to content

Commit

Permalink
docs(s2n-quic): cleaning up references to old issues (#2270)
Browse files Browse the repository at this point in the history
  • Loading branch information
WesleyRosenblum committed Jul 11, 2024
1 parent ec6f50d commit 17129d6
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 111 deletions.
5 changes: 0 additions & 5 deletions quic/s2n-quic-core/src/crypto/application/limited.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,11 @@ impl Default for Limits {
}
}

// TODO: This should be configured through the limit provider.
// https://github.com/aws/s2n-quic/issues/322
const KEY_UPDATE_WINDOW: u64 = 10_000;

impl<K: OneRttKey> Key<K> {
pub fn new(key: K) -> Self {
Key {
// TODO: This should be configured through the limit provider, the default being the
// key's AEAD limit.
// https://github.com/aws/s2n-quic/issues/322
confidentiality_limit: key.aead_confidentiality_limit(),
key,
encrypted_packets: 0,
Expand Down
19 changes: 0 additions & 19 deletions quic/s2n-quic-transport/src/connection/connection_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1475,25 +1475,6 @@ impl<Config: endpoint::Config> connection::Trait for ConnectionImpl<Config> {
},
});

//= https://www.rfc-editor.org/rfc/rfc9001#section-5.7
//= type=TODO
//= tracking-issue=320
//# Received
//# packets protected with 1-RTT keys MAY be stored and later decrypted
//# and used once the handshake is complete.

//= https://www.rfc-editor.org/rfc/rfc9001#section-5.7
//= type=TODO
//= tracking-issue=320
//= feature=0-RTT
//# The server MAY retain these packets for
//# later decryption in anticipation of receiving a ClientHello.

//= https://www.rfc-editor.org/rfc/rfc9000#section-5.2.1
//= type=TODO
//# The client MAY drop these packets, or it MAY buffer them in
//# anticipation of later packets that allow it to compute the key.

return Ok(());
}

Expand Down
2 changes: 1 addition & 1 deletion quic/s2n-quic-transport/src/space/session_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ impl<'a, Config: endpoint::Config, Pub: event::ConnectionPublisher>

let cipher_suite = key.cipher_suite().into_event();

// TODO: also store the header_key https://github.com/aws/s2n-quic/issues/319
// TODO: also store the header_key
*self.zero_rtt_crypto = Some(Box::new(key));

self.publisher.on_key_update(event::builder::KeyUpdate {
Expand Down
69 changes: 0 additions & 69 deletions specs/todos/tls/5.6.toml

This file was deleted.

17 changes: 0 additions & 17 deletions specs/todos/tls/6.6.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,3 @@ for the selected AEAD permits.
'''
tracking-issue = "450"
feature = "AEAD limits"

[[TODO]]
quote = '''
It is RECOMMENDED that endpoints immediately close the
connection with a connection error of type AEAD_LIMIT_REACHED before
reaching a state where key updates are not possible.
'''
tracking-issue = "322"
feature = "AEAD limits"

[[TODO]]
quote = '''
Endpoints that limit the size of packets MAY use higher
confidentiality and integrity limits; see Appendix B for details.
'''
tracking-issue = "322"
feature = "AEAD limits"

0 comments on commit 17129d6

Please sign in to comment.