Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading pointstore #284

Merged
merged 4 commits into from
Jan 12, 2022
Merged

upgrading pointstore #284

merged 4 commits into from
Jan 12, 2022

Conversation

sudiptoguha
Copy link
Contributor

Description of changes: Upgrades the pointstore in RCF2.0 and prepares for the 3.0 version. The state classes are unchanged.

@sudiptoguha sudiptoguha requested a review from jotok January 4, 2022 16:43
@@ -296,7 +296,7 @@ public RCF3(Builder<?> builder) {
}

private void initCompactFloat(Builder<?> builder) {
IPointStore tempStore = RCF3PointStore.builder().capacity(pointStoreCapacity).initialSize(2 * sampleSize)
IPointStore tempStore = PointStore.builder().capacity(pointStoreCapacity).initialSize(2 * sampleSize)
.internalShinglingEnabled(internalShinglingEnabled).shingleSize(shingleSize).dimensions(dimensions)
// .dynamicResizingEnabled(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@@ -42,6 +44,60 @@ public IntervalManager(int capacity) {
freeIndexesEnd[0] = capacity - 1;
}

static BitSet toBits(int[] refCount) {
checkArgument(refCount != null, " not meaninglful");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in error message

if (first < 0) {
break;
}
} else { // we do not all distiction between all full and all empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not distinguish between?

return capacity;
}

/**
* @return the number of nodes whose data is currently stored.
* @return the number of indices whioch are being maintained
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants