Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #81 scrollbar #83

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: #81 scrollbar #83

merged 1 commit into from
Jul 23, 2024

Conversation

32teeth
Copy link
Contributor

@32teeth 32teeth commented Jul 19, 2024

Problem

Solution

Everything that needs / requires a scrollbar predicated by overflow conditions now has a scrollbar

  • The gutter is unset meaning, it won't be there and be ugly.
  • The draggable part is colored using css color mix blended in with white hs; hsl(0, 100%, 100%) @ 90% which stays within the theme, and considerable enough for visual distinction
* {
  scrollbar-gutter: unset;
  scrollbar-color: color-mix(
    in hsl,
    var(--mynah-color-text-default),
    hsl(0, 100%, 100%) 90%)
    transparent;
}
Screenshot 2024-07-19 at 8 03 03 AM

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@32teeth 32teeth requested a review from a team as a code owner July 19, 2024 12:18
@volodkevych
Copy link
Contributor

Is there a reason to have scrollbar visible all the time? Where are requirements coming from? Should it be configurable? For example, Google Chrome has the same scrollbar style as MynahUI currently and I like it, tbh.

@32teeth
Copy link
Contributor Author

32teeth commented Jul 20, 2024

Is there a reason to have the scrollbar visible all the time? Where are requirements coming from? Should it be configurable? For example, Google Chrome has the same scrollbar style as MynahUI currently, and I like it, to be honest.

The scrollbar by default never shows up for me, hence the change. The appearing/disappearing scrollbar will also be set by the user's OS preferences.

From an accessibility perspective, having the scrollbar always visible can benefit users with motor impairments or those who rely on visual cues for navigation. Ensuring that UI elements like scrollbars are consistently present can enhance usability for all users, making it easier to interact with content regardless of their individual needs or preferences. Thus, providing a configurable option allows us to cater to diverse accessibility requirements.

@ege0zcan ege0zcan merged commit eaa7983 into aws:main Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants