feat: implement observability for usage of deprecated AMIs #7362

shabbskagalwala · 2024-11-11T19:24:56Z

Fixes #N/A

Description

This PR implements the RFC for observability around deprecated AMIs #7145

How was this change tested?

Change was tested by deploying in local EKS cluster, running tests using make test and make deflake

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-11-11T19:25:23Z

✅ Deploy Preview for karpenter-docs-prod ready!

Name	Link
🔨 Latest commit	`62d85cf`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6757432b00e89600088d46c5
😎 Deploy Preview	https://deploy-preview-7362--karpenter-docs-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

engedaam

Nice Work!

pkg/controllers/nodeclass/status/ami.go

pkg/apis/v1/ec2nodeclass_status.go

pkg/controllers/nodeclass/status/ami.go

pkg/controllers/nodeclass/status/ami_test.go

pkg/apis/v1/ec2nodeclass_status.go

pkg/controllers/nodeclass/status/ami.go

coveralls · 2024-11-21T22:07:37Z

Pull Request Test Coverage Report for Build 12242754435

Details

10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 65.062%

Files with Coverage Reduction	New Missed Lines	%
pkg/fake/utils.go	2	94.56%

Totals
Change from base Build 12242082771:	0.02%
Covered Lines:	5743
Relevant Lines:	8827

💛 - Coveralls

engedaam

/karpenter snapshot

github-actions · 2024-11-21T23:26:34Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4f84eced038ed1dbb328850e9971ee9e59580c34.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4f84eced038ed1dbb328850e9971ee9e59580c34" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-11-23T03:23:45Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-02c148f3abb507041fb3bd756076210ad25cf117.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-02c148f3abb507041fb3bd756076210ad25cf117" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

LGTM 🚀

test/suites/drift/suite_test.go

engedaam

/karpenter snapshot

github-actions · 2024-11-26T08:25:58Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-9bd86e7c427528a6790b1d1a1f9e6b5f57b1a9aa.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-9bd86e7c427528a6790b1d1a1f9e6b5f57b1a9aa" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

test/suites/drift/suite_test.go

engedaam

/karpenter snapshot

github-actions · 2024-12-03T23:29:30Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-cc01e3a49efc57f7222a4ea6c8197e5b17ae16e9.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-cc01e3a49efc57f7222a4ea6c8197e5b17ae16e9" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

engedaam

/karpenter snapshot

github-actions · 2024-12-07T17:17:12Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-058293d70a20479928c4cfb866ab1c1e35b7f9f2.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-058293d70a20479928c4cfb866ab1c1e35b7f9f2" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

LGTM 🚀

shabbskagalwala requested a review from a team as a code owner November 11, 2024 19:24

shabbskagalwala requested a review from jmdeal November 11, 2024 19:24

engedaam reviewed Nov 13, 2024

View reviewed changes

jonathan-innis reviewed Nov 14, 2024

View reviewed changes

pkg/apis/v1/ec2nodeclass_status.go Outdated Show resolved Hide resolved

pkg/controllers/nodeclass/status/ami.go Outdated Show resolved Hide resolved

pkg/controllers/nodeclass/status/ami.go Outdated Show resolved Hide resolved

shabbskagalwala force-pushed the feat/deprecated-ami-observability branch 2 times, most recently from f07783f to 17fc23f Compare November 20, 2024 22:25

shabbskagalwala requested review from jonathan-innis and engedaam November 21, 2024 21:53

engedaam reviewed Nov 21, 2024

View reviewed changes

shabbskagalwala force-pushed the feat/deprecated-ami-observability branch from 4f84ece to 169d6e5 Compare November 22, 2024 20:52

engedaam reviewed Nov 23, 2024

View reviewed changes

engedaam previously approved these changes Nov 25, 2024

View reviewed changes

shabbskagalwala dismissed engedaam’s stale review via 7fdfa6e November 25, 2024 21:54

shabbskagalwala force-pushed the feat/deprecated-ami-observability branch from 02c148f to 7fdfa6e Compare November 25, 2024 21:54

engedaam reviewed Nov 25, 2024

View reviewed changes

test/suites/drift/suite_test.go Outdated Show resolved Hide resolved

shabbskagalwala force-pushed the feat/deprecated-ami-observability branch from 6b0b091 to 9bd86e7 Compare November 26, 2024 04:29

engedaam reviewed Nov 26, 2024

View reviewed changes

test/suites/drift/suite_test.go Show resolved Hide resolved

implement observability for usage of deprecated AMIs

38486bc

shabbskagalwala force-pushed the feat/deprecated-ami-observability branch from 1f9dd60 to 38486bc Compare December 2, 2024 16:35

shabbskagalwala added 2 commits December 2, 2024 09:35

Merge branch 'main' into feat/deprecated-ami-observability

c6e7071

Merge branch 'main' into feat/deprecated-ami-observability

cc01e3a

engedaam reviewed Dec 3, 2024

View reviewed changes

Merge branch 'main' into feat/deprecated-ami-observability

d33e938

engedaam reviewed Dec 5, 2024

View reviewed changes

Merge branch 'main' into feat/deprecated-ami-observability

058293d

engedaam reviewed Dec 7, 2024

View reviewed changes

engedaam approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'main' into feat/deprecated-ami-observability

62d85cf

engedaam merged commit 29dfc5f into aws:main Dec 10, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement observability for usage of deprecated AMIs #7362

feat: implement observability for usage of deprecated AMIs #7362

shabbskagalwala commented Nov 11, 2024 •

edited

Loading

netlify bot commented Nov 11, 2024 •

edited

Loading

engedaam left a comment

coveralls commented Nov 21, 2024 •

edited

Loading

engedaam left a comment

github-actions bot commented Nov 21, 2024

engedaam left a comment

github-actions bot commented Nov 23, 2024

engedaam left a comment

engedaam left a comment

github-actions bot commented Nov 26, 2024

engedaam left a comment

github-actions bot commented Dec 3, 2024

engedaam left a comment

engedaam left a comment

github-actions bot commented Dec 7, 2024

engedaam left a comment

feat: implement observability for usage of deprecated AMIs #7362

feat: implement observability for usage of deprecated AMIs #7362

Conversation

shabbskagalwala commented Nov 11, 2024 • edited Loading

netlify bot commented Nov 11, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod ready!

engedaam left a comment

Choose a reason for hiding this comment

coveralls commented Nov 21, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12242754435

Details

💛 - Coveralls

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 23, 2024

engedaam left a comment

Choose a reason for hiding this comment

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2024

engedaam left a comment

Choose a reason for hiding this comment

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2024

engedaam left a comment

Choose a reason for hiding this comment

shabbskagalwala commented Nov 11, 2024 •

edited

Loading

netlify bot commented Nov 11, 2024 •

edited

Loading

coveralls commented Nov 21, 2024 •

edited

Loading