Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick chart change v0.36.x #7294

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 28, 2024

Fixes #N/A

Description
Templates karpenter-crd charts so that apiserver is able to correctly perform lookups if upgrading/installing to this version with webhooks disabled.

How was this change tested?
Webhook test suite.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit f371567
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/671fcda7ecf0ea0008911063
😎 Deploy Preview https://deploy-preview-7294--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rschalo rschalo changed the base branch from main to release-v0.36.x October 28, 2024 17:45
@rschalo rschalo marked this pull request as ready for review October 28, 2024 17:49
@rschalo rschalo requested a review from a team as a code owner October 28, 2024 17:49
@rschalo rschalo requested a review from bwagner5 October 28, 2024 17:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11559703011

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.287%

Totals Coverage Status
Change from base Build 11453277059: 0.01%
Covered Lines: 5686
Relevant Lines: 7263

💛 - Coveralls

@rschalo rschalo changed the title Cherry pick chart change 36 fix Cherry pick chart change v0.36.x Oct 28, 2024
@rschalo rschalo changed the title fix Cherry pick chart change v0.36.x fix: Cherry pick chart change v0.36.x Oct 28, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit c6cc769 into aws:release-v0.36.x Oct 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants