feat: Add new configuration for service CIDR to enable Windows bootstrapping #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
tzifudzi
added a commit
to tzifudzi/karpenter
that referenced
this pull request
Sep 14, 2023
tzifudzi
force-pushed
the
feat/windows-service-cidr
branch
from
6fb961b to
02ee419
Compare
tzifudzi
changed the title
tzifudzi
added a commit
to tzifudzi/karpenter
that referenced
this pull request
Sep 14, 2023
tzifudzi
force-pushed
the
feat/windows-service-cidr
branch
from
02ee419 to
51d1de9
Compare
tzifudzi
force-pushed
the
feat/windows-service-cidr
branch
from
51d1de9 to
5ae7396
Compare
| @@ -172,6 +172,8 @@ settings: | |||
| # -- Cluster endpoint. If not set, will be discovered during startup (EKS only) | |||
| clusterEndpoint: "" | |||
| # -- The default instance profile to use when launching nodes | |||
| clusterServiceIpv4Cidr: "" | |||
There was a problem hiding this comment.
Is it possible to discover this value from the cluster rather than specifying it within the karpenter-global-settings?
There was a problem hiding this comment.
Yes its possible. Currently it is discovering the value from the EKS cluster if the value is not specified. Perhaps we can skip having it in karpenter-global-settings altogether and rely on automatically fetching it?
|
Discussed offline with @tzifudzi: Looking into some options for users to specify this from environment variables in the |
|
Closing this PR in favour of a different approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4088
Description
TODO
How was this change tested?
TODO
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.