Skip to content

Commit

Permalink
chore: Only support Ready Node Condition for Node Repair (#7410)
Browse files Browse the repository at this point in the history
  • Loading branch information
engedaam authored Nov 20, 2024
1 parent 809c2f1 commit bbb4996
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
10 changes: 0 additions & 10 deletions pkg/cloudprovider/cloudprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,16 +254,6 @@ func (c *CloudProvider) RepairPolicies() []cloudprovider.RepairPolicy {
ConditionStatus: corev1.ConditionFalse,
TolerationDuration: 30 * time.Minute,
},
{
ConditionType: corev1.NodeDiskPressure,
ConditionStatus: corev1.ConditionTrue,
TolerationDuration: 30 * time.Minute,
},
{
ConditionType: corev1.NodeMemoryPressure,
ConditionStatus: corev1.ConditionTrue,
TolerationDuration: 30 * time.Minute,
},
}
}

Expand Down
10 changes: 0 additions & 10 deletions test/suites/integration/repair_policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,6 @@ var _ = Describe("Repair Policy", func() {
Status: corev1.ConditionFalse,
LastTransitionTime: metav1.Time{Time: time.Now().Add(-31 * time.Minute)},
}),
Entry("DiskPressure", corev1.NodeCondition{
Type: corev1.NodeDiskPressure,
Status: corev1.ConditionTrue,
LastTransitionTime: metav1.Time{Time: time.Now().Add(-31 * time.Minute)},
}),
Entry("MemoryPressure", corev1.NodeCondition{
Type: corev1.NodeMemoryPressure,
Status: corev1.ConditionTrue,
LastTransitionTime: metav1.Time{Time: time.Now().Add(-31 * time.Minute)},
}),
)
It("should ignore disruption budgets", func() {
nodePool.Spec.Disruption.Budgets = []karpenterv1.Budget{
Expand Down

0 comments on commit bbb4996

Please sign in to comment.