Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): make kernel 'load' operation synchronous #951

Merged
merged 4 commits into from
Nov 7, 2019
Merged

fix(runtime): make kernel 'load' operation synchronous #951

merged 4 commits into from
Nov 7, 2019

Commits on Nov 7, 2019

  1. fix(runtime): make kernel 'load' operation synchronous 

    The `jsii-runtime` process cannot perform async operations while waiting
for a (synchronous) callback to return (the response flow is otherwise
ambiguous). In order to allow loading of dependencies within a calllback
flow, the `load` kernel API needed to be made syncrhonous.

The reason why this is needed is because the host languages runtime
libraries may be required to load dependencies at the last minute, for
it may not be possible to determine what dependencies are required
before  a callback is executed.

Introduced a (unit) test to confirm the `jsii-runtime` is indeed able to
perform `load` operations within a callback context.
    @RomainMuller
    RomainMuller committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    7fec6ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/allow-load-from-callback

    @RomainMuller
    RomainMuller committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    20cbffe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rmuller/allow-load-from-callback

    @mergify
    mergify[bot] committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    7fb8808 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into rmuller/allow-load-from-callback

    @mergify
    mergify[bot] committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    3f176b9 View commit details
    Browse the repository at this point in the history