fix(java,dotnet): emit default implementations for optional properties #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For optional properties on interfaces, emit default implementations when possible (for .NET, this requires `netcoreapp3.0` or later) so that adding a new optional property on an interface does not break existing core that implements the interface. In it's current form, the getters always return `null`, while the setters throw an exception (this may change in the future). Fixes #543
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Oct 25, 2019
RomainMuller
force-pushed
the
rmuller/optional-members-in-static-languages
branch
from
1616327
to
7632290
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For optional properties on interfaces, emit default implementations (for .NET,
this required upgrading the target to
netcoreapp3.0) so that adding a newoptional property on an interface does not break existing code that implements
the interface.
In it's current form, the getters always return
null, while the setters throw anexception unless overridden.
Fixes #543
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.