Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet): use snupkg format for dotnet symbol packages #830

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

RomainMuller
Copy link
Contributor

The legacy format is not supported by NuGet's own symbols server, and the
SymbolSource server is currently experiencing a certificate expiration event,
which seems to be a somewhat recurring issue (NuGet/Home#6082).

More info: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The legacy format is not supported by NuGet's own symbols server, and the
SymbolSource server is currently experiencing a certificate expiration event,
which seems to be a somewhat recurring issue (NuGet/Home#6082).

More info: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg
@RomainMuller RomainMuller requested a review from a team as a code owner September 30, 2019 10:08
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When releasing, please cherry-pick this into a patch release, so we don't bring in new features when trying to unblock the CDK pipeline.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Sep 30, 2019
@mergify mergify bot merged commit 0d18b4d into master Sep 30, 2019
@RomainMuller RomainMuller deleted the rmuller/snupkg branch September 30, 2019 10:28
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Sep 30, 2019
RomainMuller added a commit that referenced this pull request Sep 30, 2019
The legacy format is not supported by NuGet's own symbols server, and the
SymbolSource server is currently experiencing a certificate expiration event,
which seems to be a somewhat recurring issue (NuGet/Home#6082).

More info: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg
RomainMuller added a commit that referenced this pull request Sep 30, 2019
The legacy format is not supported by NuGet's own symbols server, and the
SymbolSource server is currently experiencing a certificate expiration event,
which seems to be a somewhat recurring issue (NuGet/Home#6082).

More info: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants