Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-diff): handle violations in Enums #730

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 23, 2019

Rendering violations in enums was not considered and so any violation
to a full enum type (typically, removing it) would cause the differ
to crash.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Rendering violations in enums was not considered and so any violation
to a full enum type (typically, removing it) would cause the differ
to crash.
@rix0rrr rix0rrr requested a review from a team as a code owner August 23, 2019 08:16
@rix0rrr rix0rrr self-assigned this Aug 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 23, 2019
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 23, 2019
@mergify mergify bot merged commit 934b5c8 into master Aug 23, 2019
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 23, 2019
@mergify mergify bot deleted the huijbers/render-enum branch August 23, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants