fix(jsii): correctly inherit initializer stability #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the inheriting of stability tags for the initializer. It used to inherit from the package, it now correctly inherits from the class. Update jsii-reflect with a "load all modules" method (to save time in a complex dependency tree) and jsii-tree with options to show stabilities.
ghost
requested a review
from 
eladb
approved these changes
Jul 1, 2019
| .positional('JSII-FILE', { type: 'string', desc: 'path to a .jsii file to load, all dependency .jsii files must be explicitly supplied' }) | ||
| .positional('MODULE-DIR', { type: 'string', desc: 'path to an jsii npm module directory, all jsii dependencies will be loaded transitively' })) | ||
| .option('closure', { type: 'string', alias: 'c', desc: 'Load dependencies of package without assuming its a JSII package itself' }) |
There was a problem hiding this comment.
Not sure I understand this feature? What is the value passed in to this switch?
Feels like you could just auto-discover this when MODULE-DIR is not a jsii module
There was a problem hiding this comment.
Well load() (and loadModule()) expects to be able to return an Assembly, and we can't return an Assembly for a non-JSII package.
RomainMuller
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inheriting of stability tags for the initializer. It used to
inherit from the package, it now correctly inherits from the class.
Update jsii-reflect with a "load all modules" method (to save time
in a complex dependency tree) and jsii-tree with options to show
stabilities.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.