Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix confusing comment about FD number 4 that does not exist #4157

Merged
merged 1 commit into from
Jun 26, 2023
Merged

chore: fix confusing comment about FD number 4 that does not exist #4157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@jsii/runtime/bin/jsii-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import { Duplex } from 'stream';
// Spawn another node process, with the following file descriptor setup:
// - No STDIN will be provided
// - STDOUT and STDERR will be intercepted, contents wrapped & forward to STDERR
// - FD#3 is the communication pipe to read jsii API messages
// - FD#4 is the communication pipe to write jsii API responses
// - FD#3 is the communication pipe to read & write jsii API messages
const child = spawn(
process.execPath,
[...process.execArgv, resolve(__dirname, '..', 'lib', 'program.js')],
Expand Down