Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Add support for synchronous callbacks #407

Merged
merged 17 commits into from
Mar 28, 2019
Merged

feat(python): Add support for synchronous callbacks #407

merged 17 commits into from
Mar 28, 2019

Commits on Mar 15, 2019

  1. WIP: Initial checkpoint, basics of synchronous callbacks are working … 

    …but only for simple, positional arguments. Also, one test for getting a property is now failing and needs to be fixed.
    Mitch Garnaat committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    5438aa4 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. A bit more progress but still not there.

    Mitch Garnaat committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    5f6856c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Still not fully working but a bit closer

    Mitch Garnaat committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    2d0b36d View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merging from master

    Mitch Garnaat committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    1c61a9f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Sync callback tests a now passing but still an issue with sync callba… 

    …cks happening in the context of async callbacks.
    Mitch Garnaat committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    0eae9c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Fixing the situation where a Callback response is sent immediately af… 

    …ter a Begin request.
    Mitch Garnaat committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    f880bff View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. WIP commit

    Mitch Garnaat committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    11d7472 View commit details
    Browse the repository at this point in the history

  2. Merging from origin/master

    Mitch Garnaat committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    705e213 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. All callback related tests now working.

    Mitch Garnaat committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    40c104a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add_sync_callback

    Mitch Garnaat committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    a4d5c87 View commit details
    Browse the repository at this point in the history

  3. Clearing the last of the xfails

    Mitch Garnaat committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    f2be47e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. Fix issue that was causing loading of incorrect version of jsii packa… 

    …ge from PyPI
    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c7d0f4c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into add_sync_callback

    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    83db854 View commit details
    Browse the repository at this point in the history

  3. Get additional test added and running

    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f30b4c8 View commit details
    Browse the repository at this point in the history

  4. Remove some cruft left over from testing.

    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    6376ec4 View commit details
    Browse the repository at this point in the history

  5. Resolving some feedback issues

    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    85f6da4 View commit details
    Browse the repository at this point in the history

  6. More checking of enum passed in test

    Mitch Garnaat committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    dac2b2a View commit details
    Browse the repository at this point in the history