fix(runtime): type not found #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a jsii module returned a private class implementation of an interface, consuming `jsii.rtti` data may return an FQN for the internal class, which does not exist in foreign languages, leading to an error. Revert to tagging FQNs directly instead. Fixes #3742
RomainMuller
force-pushed
the
rmuller/type-not-found
branch
from
ada1dcb
to
585db30
Compare
# Conflicts: # .all-contributorsrc # README.md
RomainMuller
added
pr/do-not-merge
iliapolo
approved these changes
Sep 22, 2022
RomainMuller
added
pr/ready-to-merge
RomainMuller
force-pushed
the
rmuller/type-not-found
branch
from
e996008
to
cbd0fde
Compare
RomainMuller
force-pushed
the
rmuller/type-not-found
branch
from
cbd0fde
to
ac2a024
Compare
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a jsii module returned a private class implementation of an interface, consuming
jsii.rttidata may return an FQN for the internal class, which does not exist in foreign languages, leading to an error.Revert to tagging FQNs directly instead.
Fixes #3742
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.