Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): .NET bindings fail to compile with error CS8120 #3760

Merged
merged 6 commits into from
Sep 22, 2022

Commits on Sep 21, 2022

  1. fix(pacmak): .NET bindings fail to compile with error CS8120

    If a type union includes several candidates that are related to each
    other (A extends B or A implements B), `jsii-pacmak` may generate type
    checking clauses in a pattern matching `switch` statement in an order
    such that the compiler identifies dead clauses, which is an error in C#.
    
    This adds a provision to NOT emit such a clause so as to not cause the
    error. It is worth mentioning that the error cannot be "opted out" of
    via a `#pragma` directive like a warning would be, which is unfortunate.
    
    Fixes #3759
    RomainMuller committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1798c2b View commit details
    Browse the repository at this point in the history
  2. linter+typo fix

    RomainMuller committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    543e88d View commit details
    Browse the repository at this point in the history
  3. fix snapshots

    RomainMuller committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    486c040 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b3095e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Configuration menu
    Copy the full SHA
    4ca6dbd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b4ef0b View commit details
    Browse the repository at this point in the history