Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): prohibit exported const enums #372

Merged
merged 1 commit into from
Mar 7, 2019

Commits on Mar 7, 2019

  1. fix(jsii): prohibit exported const enums

    'const enums' are inlined at the usage site by TypeScript and so the
    generated type will not be in the JavaScript source code in the
    assembly, even though the declaration will be there.
    
    This leads to "symbol not found" errors upon trying to load it.
    
    https://www.typescriptlang.org/docs/handbook/enums.html#const-enums
    
    Fixes aws/aws-cdk#1969
    Rico Huijbers committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6f440b5 View commit details
    Browse the repository at this point in the history