fix(jsii): deprecation warnings use this.constructor before calling super #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uper Instead of using `this.constructor`, inline the class name (which has the same value as `this.constructor` anyway). This removes what can be seen as a semantic issue (as it is usually illegal to refer to `this` before having called `super` in strict mode).
rix0rrr
approved these changes
May 9, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
this.constructor, inline the class name (which hasthe same value as
this.constructoranyway). This removes what can beseen as a semantic issue (as it is usually illegal to refer to
thisbefore having called
superin strict mode).Fixes #3527
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.