Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): deprecation warnings erroneously warn for duplicate enum values #3105

Merged
merged 2 commits into from
Oct 28, 2021
Merged

fix(jsii): deprecation warnings erroneously warn for duplicate enum values #3105

merged 2 commits into from
Oct 28, 2021

Commits on Oct 28, 2021

  1. fix(jsii): deprecation warnings erroneously warn for duplicate enum v… 

    …alues

The deprecation warnings feature will warn if an enum value is used which is
equal to one to a deprecated enum member. Unfortunately, in the case of an enum
with duplicate values, there is no way to tell whether the deprecated member was
used (or not). The current behavior emits warnings even in cases where the
active/undeprecated member is being used.

This change flips the behavior to mute the notification in the case where the
value used is a known duplicate value. This results in erring on the side of
false negatives (not catching deprecated usage) over false positives (warning in
the case nothing's wrong).

fixes #3103
    @njlynch
    njlynch committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    7e3dedb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into njlynch/fix-3103

    @mergify
    mergify[bot] authored Oct 28, 2021
    Configuration menu
    Copy the full SHA
    19e4d2b View commit details
    Browse the repository at this point in the history