Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove overly strict checks on peer versions #306

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 9, 2018

  1. ProjectInfo was verifying that the specified version range in
    peerDependencies is exactly the same as the version range in regular
    dependencies. This is not necessary, the only requirement is that
    the actual concrete dependency version satisfies the peer dependency
    version (which is already checked in _loadDependencies).

  2. Assembler was verifying that the concrete version of a library found
    in dependencies was the same as that same concrete library found in
    peerDependencies. But since there's ever only one concrete copy of
    any dependency, this check can never fail.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

1) ProjectInfo was verifying that the specified version range in
   peerDependencies is exactly the same as the version range in regular
   dependencies. This is not necessary, the only requirement is that
   the actual concrete dependency version satisfies the peer dependency
   version (which is already checked in _loadDependencies).

2) Assembler was verifying that the concrete version of a library found
   in dependencies was the same as that same concrete library found in
   peerDependencies. But since there's ever only one concrete copy of
   any dependency, this check can never fail.
@rix0rrr rix0rrr merged commit 7b89d01 into master Nov 9, 2018
@rix0rrr rix0rrr deleted the huijbers/no-peer-version-checks branch November 9, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants