fix(pacmak): multiple go (and python) issues #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `go build` command we run during pacmak did not descend into submodules. After adding `./...` to the `go build` command, a few other issues were surfaced related to static member handling. The common issue was that `GoClass` had two separate lists (for static and non-static methods/props). This caused various places in the implementation to only take into account non-static members. Added a new list called `members` which collected both static and non-static members and used it in the various dependency props. An empty module in Python (with only submodules) will result in an empty `__all__` list which yields a MyPy error. Fixes #2618 - go build does not build submodule directories Fixes #2619 - go/python module with only submodules (no direct types) fails compilation Fixes #2620 - go missing imports if class includes only static members Fixes #2621 - invalid go imports when types referenced by static members
eladb
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
approved these changes
Mar 1, 2021
This was referenced Mar 9, 2021
5 tasks
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
mergify bot
referenced
this pull request
in projen/projen
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [jsii-pacmak](https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak) from 1.24.0 to 1.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-pacmak's releases</a>.</em></p> <blockquote> <h2>v1.25.0</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-pacmak's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2704">#2704</a>)</li> <li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2696">#2696</a>)</li> <li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li> <li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2691">#2691</a>)</li> <li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2685">#2685</a>)</li> <li><a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03"><code>9562108</code></a> feat(go): packageName and versionSuffix (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2687">#2687</a>)</li> <li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2650">#2650</a>)</li> <li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2674">#2674</a>)</li> <li><a href="https://github.com/aws/jsii/commit/d6140ce2e7b94984f7042a920f550b3b0ac22f8d"><code>d6140ce</code></a> chore(go): make Load call idempotent (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2645">#2645</a>)</li> <li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2644">#2644</a>)</li> <li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-pacmak">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
This was referenced Mar 17, 2021
mergify bot
referenced
this pull request
in cdktf/cdktf-provider-github
Mar 17, 2021
Bumps [jsii-diff](https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff) from 1.24.0 to 1.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-diff's releases</a>.</em></p> <blockquote> <h2>v1.25.0</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-diff's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2696">#2696</a>)</li> <li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2674">#2674</a>)</li> <li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2644">#2644</a>)</li> <li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-diff">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
referenced
this pull request
in cdktf/cdktf-provider-github
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [jsii-pacmak](https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak) from 1.24.0 to 1.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-pacmak's releases</a>.</em></p> <blockquote> <h2>v1.25.0</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-pacmak's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2704">#2704</a>)</li> <li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2696">#2696</a>)</li> <li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li> <li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2691">#2691</a>)</li> <li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2685">#2685</a>)</li> <li><a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03"><code>9562108</code></a> feat(go): packageName and versionSuffix (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2687">#2687</a>)</li> <li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2650">#2650</a>)</li> <li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2674">#2674</a>)</li> <li><a href="https://github.com/aws/jsii/commit/d6140ce2e7b94984f7042a920f550b3b0ac22f8d"><code>d6140ce</code></a> chore(go): make Load call idempotent (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2645">#2645</a>)</li> <li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2644">#2644</a>)</li> <li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-pacmak">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
referenced
this pull request
in cdktf/cdktf-provider-github
Mar 17, 2021
Bumps [jsii](https://github.com/aws/jsii/tree/HEAD/packages/jsii) from 1.24.0 to 1.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii's releases</a>.</em></p> <blockquote> <h2>v1.25.0</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2696">#2696</a>)</li> <li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2650">#2650</a>)</li> <li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2674">#2674</a>)</li> <li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2644">#2644</a>)</li> <li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
referenced
this pull request
in cdklabs/jsii-docgen
Mar 17, 2021
Bumps [jsii-reflect](https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect) from 1.24.0 to 1.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-reflect's releases</a>.</em></p> <blockquote> <h2>v1.25.0</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-reflect's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2> <h3>Features</h3> <ul> <li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li> <li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li> <li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li> <li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li> <li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li> <li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2704">#2704</a>)</li> <li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2696">#2696</a>)</li> <li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li> <li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2691">#2691</a>)</li> <li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2685">#2685</a>)</li> <li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2650">#2650</a>)</li> <li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2674">#2674</a>)</li> <li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates && yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2644">#2644</a>)</li> <li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-reflect">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go buildcommand we run during pacmak did not descend into submodules. After adding./...to thego buildcommand, a few other issues were surfaced related to static member handling.The common issue was that
GoClasshad two separate lists (for static and non-static methods/props). This caused various places in the implementation to only take into account non-static members. Added a new list calledmemberswhich collected both static and non-static members and used it in the various dependency props.An empty module in Python (with only submodules) will result in an empty
__all__list which yields a MyPy error.Fixes #2618 - go build does not build submodule directories
Fixes #2619 - go/python module with only submodules (no direct types) fails compilation
Fixes #2620 - go missing imports if class includes only static members
Fixes #2621 - invalid go imports when types referenced by static members
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.