Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rosetta): variadic arguments may use kwargs syntax in Python #1832

Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix(rosetta): variadic arguments may use kwargs syntax in Python #1832

merged 2 commits into from
Jul 29, 2020

Commits on Jul 29, 2020

  1. fix(rosetta): variadic arguments may use kwargs syntax in Python 

    When processing function calls, the signature of the function was not
considered when it was available, and an object literal used as the
final argument of a variadic call would be rendered as keyword arguments
when this is actually not a correct way to render variadic values.

This change attempts to read the resolved signature of the function
beging called, in order to correctly render variadic values.

Fixes #1821
    @RomainMuller
    RomainMuller committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    00bf686 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/rosetta-varargs

    @mergify
    mergify[bot] authored Jul 29, 2020
    Configuration menu
    Copy the full SHA
    31d5d03 View commit details
    Browse the repository at this point in the history