Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): build succeeds using Omit<T, K> #1708

Merged
merged 3 commits into from
Jun 8, 2020
Merged

fix(jsii): build succeeds using Omit<T, K> #1708

merged 3 commits into from
Jun 8, 2020

Commits on Jun 2, 2020

  1. fix(jsii): build succeeds using Omit<T, K> 

    When using the `Omit<T, K>` helper type (a mapped type) on an exported
API, `jsii` should detect this and fail, instead of allowing the
application to compile.

An additional bug caused use of this type to result in a successful exit
code from `jsii`, while the `.jsii` file was never written. This has
also been fixed.

Fixes #1707
    @RomainMuller
    RomainMuller committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    842baa8 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge branch 'master' into rmuller/omit

    @mergify
    mergify[bot] committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    9155bd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Merge branch 'master' into rmuller/omit

    @RomainMuller
    RomainMuller committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    4bbb3df View commit details
    Browse the repository at this point in the history