Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): "any" serialization breaks private type instances #1347

Merged
merged 7 commits into from
Mar 18, 2020
Merged

fix(kernel): "any" serialization breaks private type instances #1347

merged 7 commits into from
Mar 18, 2020

Commits on Mar 18, 2020

  1. fix(kernel): "any" serialization breaks private type instances 

    When a "private" type (aka a class that is not visible in the `.jsii`
assembly) is passed from JS to Host through an `any`-typed entity, the
value was serialized by-value, passing only the instance's properties,
and omitting any methods.

This changes the behavior of the `SerializationClass.Any` serializer,
so that when an anonymous object is encountered, if it has a dynamic
getter, setter or any method (including a constructor), it is passed
by-reference instead of by-value.

Fixes aws/aws-cdk#6746
    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    8221e5e View commit details
    Browse the repository at this point in the history

  2. Correct fallback

    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    5768ccc View commit details
    Browse the repository at this point in the history

  3. Clarify specification around this use-case

    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    940ec23 View commit details
    Browse the repository at this point in the history

  4. Fix end condition to correctly detect Object proto by absence of a pa… 

    …rent
    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    7cb08ae View commit details
    Browse the repository at this point in the history

  5. Fix python runtime

    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    63a887d View commit details
    Browse the repository at this point in the history

  6. Document developmment/iteration workflow for python tests

    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    24341f2 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into rmuller/fix-token-though-any

    @RomainMuller
    RomainMuller committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    5e414a0 View commit details
    Browse the repository at this point in the history