fix(rosetta): properly escape C# comments as XML #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C# compiler will completely drop comment blocks that aren't well-formed XML; the <img> tag we were outputting wasn't, and so namespace headings weren't being generated. At the same time, pay more attention to escaping of arbitrary HTML and the text inside attributes to minimize the chances of things going wrong in the future.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Jan 9, 2020
|
That is a fair question. I will endeavor to find out. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…/packages/jsii-pacmak/lib/targets/python (#4720) Updates the requirements on [twine](https://github.com/pypa/twine) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/twine/blob/main/docs/changelog.rst">twine's changelog</a>.</em></p> <blockquote> <h2>Twine 6.0.1 (2024-11-30)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Fixed a regression where <code>twine check</code> would fail to expand wildcards, e.g. <code>twine check 'dist/*'</code>. (<code>[#1188](pypa/twine#1188) <https://github.com/pypa/twine/issues/1188></code>_)</li> </ul> <p>Misc ^^^^</p> <ul> <li><code>[#1184](pypa/twine#1184) <https://github.com/pypa/twine/issues/1184></code>_</li> </ul> <h2>Twine 6.0.0 (2024-11-29)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Restore support for pkginfo 1.11 (<code>[#1116](pypa/twine#1116) <https://github.com/pypa/twine/issues/1116></code>_)</li> </ul> <p>Deprecations and Removals ^^^^^^^^^^^^^^^^^^^^^^^^^</p> <ul> <li>Username for PyPI and Test PyPI now defaults to <strong>token</strong> but no longer overrides a username configured in the environment or supplied on the command line. Workflows still supplying anything other than <strong>token</strong> for the username when uploading to PyPI or Test PyPI will now fail. Either supply <strong>token</strong> or do not supply a username at all. (<code>[#1121](pypa/twine#1121) <https://github.com/pypa/twine/issues/1121></code>_)</li> </ul> <p>Misc ^^^^</p> <ul> <li><code>[#1024](pypa/twine#1024) <https://github.com/pypa/twine/issues/1024></code>_</li> </ul> <h2>Twine 5.1.1 (2024-06-26)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li> <p>Resolve DeprecationWarnings when extracting <code>twine</code> metadata. (<code>[#1115](pypa/twine#1115) <https://github.com/pypa/twine/issues/1115></code>_)</p> </li> <li> <p>Fix bug for Repository URLs with auth where the port was lost. When attempting to prevent printing authentication credentials in URLs provided with username and password, we did not properly handle the case where the URL also contains a port (when reconstructing the URL). This is now handled and tested to ensure no regressions. (<code>#fix-repo-urls-with-auth-and-port <https://github.com/pypa/twine/issues/fix-repo-urls-with-auth-and-port></code>_)</p> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/twine/commit/a723876fd4398be57838873e60867566b6220a53"><code>a723876</code></a> Merge pull request <a href="https://redirect.github.com/pypa/twine/issues/1189">#1189</a> from pypa/release-6.0.1</li> <li><a href="https://github.com/pypa/twine/commit/9a24828cbded183d02d0b3f5a8af41b7764dda98"><code>9a24828</code></a> Update changelog for 6.0.1</li> <li><a href="https://github.com/pypa/twine/commit/a0170058016cb7ed9554ef648a48c1899917d255"><code>a017005</code></a> Merge pull request <a href="https://redirect.github.com/pypa/twine/issues/1188">#1188</a> from pypa/ww/fix-twine-check-glob</li> <li><a href="https://github.com/pypa/twine/commit/e98f03bb0932e364065f827f804806bacccc436d"><code>e98f03b</code></a> check: fix handling of non-shell-expanded globs</li> <li><a href="https://github.com/pypa/twine/commit/873f33ed40bb38407a87abba6cd2a65f35eb6286"><code>873f33e</code></a> build(deps): bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 (<a href="https://redirect.github.com/pypa/twine/issues/1175">#1175</a>)</li> <li><a href="https://github.com/pypa/twine/commit/067412e84cfdd39929d838075ef8fa3d2cb0d733"><code>067412e</code></a> Use brackets for the default value of option arguments (<a href="https://redirect.github.com/pypa/twine/issues/1149">#1149</a>)</li> <li><a href="https://github.com/pypa/twine/commit/f32dc3545b52389dac0cbd28059833d48c36b4f4"><code>f32dc35</code></a> Apply ruff/Perflint rule (<a href="https://redirect.github.com/pypa/twine/issues/1136">#1136</a>)</li> <li><a href="https://github.com/pypa/twine/commit/aa58273f52afab52d3dd00b2c6cf3b472c6ee20d"><code>aa58273</code></a> Don't require importlib_metadata on Python 3.10+</li> <li><a href="https://github.com/pypa/twine/commit/675565f35c6d0adc435c9da6cb123f41dcaeffb8"><code>675565f</code></a> changelog: record <a href="https://redirect.github.com/pypa/twine/issues/1184">#1184</a></li> <li><a href="https://github.com/pypa/twine/commit/80cc58c0ddbd68b107c4709be5072f3e309b843c"><code>80cc58c</code></a> chore: mark 3.13 as explicitly supported</li> <li>Additional commits viewable in <a href="https://github.com/pypa/twine/compare/v5.1.1...6.0.1">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…/packages/jsii-pacmak/lib/targets/python (#4749) Updates the requirements on [twine](https://github.com/pypa/twine) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/twine/blob/main/docs/changelog.rst">twine's changelog</a>.</em></p> <blockquote> <h2>Twine 6.1.0 (2025-01-17)</h2> <p>Features ^^^^^^^^</p> <ul> <li>Twine now has preliminary built-in support for <code>Trusted Publishing <https://docs.pypi.org/trusted-publishers/></code>_ as an authentication mechanism. (<code>[#1194](pypa/twine#1194) <https://github.com/pypa/twine/pull/1194></code>_)</li> </ul> <p>Deprecations and Removals ^^^^^^^^^^^^^^^^^^^^^^^^^</p> <ul> <li> <p>Remove support for <code>egg</code> and <code>wininst</code> distribution types. These are not accepted by PyPI and not produced by any modern build-backends. (<code>[#1195](pypa/twine#1195) <https://github.com/pypa/twine/issues/1195></code>_)</p> </li> <li> <p>Twine no longer supports <code>.tar.bz2</code> source distributions. (<code>[#1200](pypa/twine#1200) <https://github.com/pypa/twine/pull/1200></code>_)</p> </li> </ul> <p>Misc ^^^^</p> <ul> <li> <p><code>packaging</code> is used instead of <code>pkginfo</code> for parsing and validating metadata. This aligns metadata validation to the one performed by PyPI. <code>packaging</code> version 24.0 or later is required. Support for metadata version 2.4 requires <code>packaging</code> 24.2 or later. <code>pkginfo</code> is not a dependency anymore. (<code>[#1180](pypa/twine#1180) <https://github.com/pypa/twine/issues/1180></code>_)</p> </li> <li> <p>Use <code>"source"</code> instead of <code>None</code> as <code>pyversion</code> for <code>sdist</code> uploads. This is what PyPI (and most likely other package indexes) expects. (<code>[#1191](pypa/twine#1191) <https://github.com/pypa/twine/issues/1191></code>_)</p> </li> </ul> <h2>Twine 6.0.1 (2024-11-30)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Fixed a regression where <code>twine check</code> would fail to expand wildcards, e.g. <code>twine check 'dist/*'</code>. (<code>[#1188](pypa/twine#1188) <https://github.com/pypa/twine/issues/1188></code>_)</li> </ul> <p>Misc ^^^^</p> <ul> <li><code>[#1184](pypa/twine#1184) <https://github.com/pypa/twine/issues/1184></code>_</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/twine/commit/aa3a910cdef8e0a3cb4e893f4c371b58015f52e0"><code>aa3a910</code></a> Update changelog for 6.1.0 (<a href="https://redirect.github.com/pypa/twine/issues/1214">#1214</a>)</li> <li><a href="https://github.com/pypa/twine/commit/440603423ac579946aec0c15b280c6ef44477400"><code>4406034</code></a> Merge pull request <a href="https://redirect.github.com/pypa/twine/issues/1208">#1208</a> from dnicolodi/rm-setuptools</li> <li><a href="https://github.com/pypa/twine/commit/2ca55db34c537bbcb00e157e407320c1e5f8f08b"><code>2ca55db</code></a> Simplify generation of test packages used in test_check</li> <li><a href="https://github.com/pypa/twine/commit/bffd2963bbc9c321670eea659d30178000a7bae7"><code>bffd296</code></a> Move build_archive() from test_sdist to common helpers module</li> <li><a href="https://github.com/pypa/twine/commit/fd0646e12e25752d136f9520d7af0d108bc1f29e"><code>fd0646e</code></a> Merge pull request <a href="https://redirect.github.com/pypa/twine/issues/1206">#1206</a> from dnicolodi/rm-binary-blobs-part1</li> <li><a href="https://github.com/pypa/twine/commit/ab4ec8cc0f926a935070731246905f3985ff735d"><code>ab4ec8c</code></a> Merge pull request <a href="https://redirect.github.com/pypa/twine/issues/1211">#1211</a> from pypa/dependabot/github_actions/actions/upload-a...</li> <li><a href="https://github.com/pypa/twine/commit/b562f7422403b0cadff694d2e81b98cf2e28894f"><code>b562f74</code></a> build(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0</li> <li><a href="https://github.com/pypa/twine/commit/b2832de88421edd0d11bfe2ceb53470e12f18bb2"><code>b2832de</code></a> Remove tests/fixtures/twine-1.5.0.zip</li> <li><a href="https://github.com/pypa/twine/commit/970851d9b188dc916e6d95083b1797bd6c277ce5"><code>970851d</code></a> Remove tests/alt-fixtures/twine-1.5.0-py2.py3-none-any.whl</li> <li><a href="https://github.com/pypa/twine/commit/2386ca5300cd7bde59432834d362c07de61e9a53"><code>2386ca5</code></a> build(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 (<a href="https://redirect.github.com/pypa/twine/issues/1205">#1205</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pypa/twine/compare/6.0.1...6.1.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# compiler will completely drop comment blocks that aren't
well-formed XML; the
<img>tag we were outputting wasn't, andso namespace headings weren't being generated.
At the same time, pay more attention to escaping of arbitrary
HTML and the text inside attributes to minimize the chances
of things going wrong in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.