Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): correctly emit slugified positional args #1081

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Commits on Nov 29, 2019

  1. fix(python): correctly emit sligified positional args

    In the implementation of kernel calls, the positional argument list did
    not use the slugified argument name (in case where such an argument had
    a name conflict with a lifted kwarg), resulting in an incorrect argument
    list to be passed to `jsii-kernel`. This typically resulted in a type
    check error in the `jsii-kernel`, but could also have silently succeeded
    at making an incorrect call.
    
    Fixes aws/aws-cdk#4302
    RomainMuller committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    03460af View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Configuration menu
    Copy the full SHA
    0cf66fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    168fc6f View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Configuration menu
    Copy the full SHA
    41324ca View commit details
    Browse the repository at this point in the history