Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii diagnostics are not emitted in "watch" mode #382

Closed
eladb opened this issue Mar 13, 2019 · 0 comments · Fixed by #383
Closed

jsii diagnostics are not emitted in "watch" mode #382

eladb opened this issue Mar 13, 2019 · 0 comments · Fixed by #383

Comments

@eladb
Copy link
Contributor

eladb commented Mar 13, 2019

No description provided.

eladb pushed a commit that referenced this issue Mar 13, 2019
fix(jsii): show jsii diagnostics in watch mode and support $tsc probl…
7e31d08 
…em matcher

Emit jsii diagnostics error when in watch mode, and also format the errors with a
"TS9999" error code so that VSCode's $tsc problem matcher will show them as
"Problems". Prefix "JSII" in the message to distinguish that these are jsii errors.

Fixes #382
@eladb eladb mentioned this issue Mar 13, 2019
Merged
eladb pushed a commit that referenced this issue Mar 13, 2019
fix(jsii): show jsii diagnostics in watch mode and support $tsc probl…
0275944 
…em matcher (#383)

Emit jsii diagnostics error when in watch mode, and also format the errors with a
"TS9999" error code so that VSCode's $tsc problem matcher will show them as
"Problems". Prefix "JSII" in the message to distinguish that these are jsii errors.

Fixes #382
eladb pushed a commit that referenced this issue Mar 18, 2019
fix(jsii): show jsii diagnostics in watch mode and support $tsc probl…
8b635b4 
…em matcher

Emit jsii diagnostics error when in watch mode, and also format the errors with a
"TS9999" error code so that VSCode's $tsc problem matcher will show them as
"Problems". Prefix "JSII" in the message to distinguish that these are jsii errors.

Fixes #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(jsii): show jsii diagnostics in watch mode and support $tsc problem matcher aws/jsii
1 participant
@eladb