chore: drop support for Node 12 #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the minimal required node release to 14.x, since Node 12 has been end-of-life since `2022-04-01`. This allows us to upgrade our TypeScript `target` from `ES2019` to `ES2020` (native support for nullish-coalescing and optional chaining, among other things). Removed the `node12` entries from the various test matrices and stop publishing `node12` tags for `jsii/superchain`. BREAKING CHANGE: Beginning with this release, jsii packages no longer support node 12. Users should migrate to a supported node release (14.x, 16.x, or 18.x).
RomainMuller
added
the
pr/do-not-merge
|
RomainMuller
force-pushed
the
main
branch
2 times, most recently
from
7c847b6
to
27c610d
Compare
RomainMuller
force-pushed
the
rmuller/remove-node-12
branch
from
6e5e460
to
a875197
Compare
# Conflicts: # packages/@jsii/check-node/package.json # packages/@jsii/dotnet-runtime-test/package.json # packages/@jsii/dotnet-runtime/package.json # packages/@jsii/go-runtime/package.json # packages/@jsii/integ-test/package.json # packages/@jsii/java-runtime/package.json # packages/@jsii/kernel/package.json # packages/@jsii/runtime/package.json # packages/@jsii/spec/package.json # packages/@scope/jsii-calc-base-of-base/package.json # packages/@scope/jsii-calc-base/package.json # packages/@scope/jsii-calc-lib/package.json # packages/codemaker/package.json # packages/jsii-calc/package.json # packages/jsii-config/package.json # packages/jsii-diff/package.json # packages/jsii-pacmak/package.json # packages/jsii-reflect/package.json # packages/jsii-rosetta/package.json # packages/jsii/lib/compiler.ts # packages/jsii/package.json # packages/oo-ascii-tree/package.json # tools/jsii-compliance/package.json # yarn.lock
RomainMuller
force-pushed
the
rmuller/remove-node-12
branch
from
a875197
to
f6cfded
Compare
RomainMuller
removed
the
pr/do-not-merge
|
This breaks our builds cause Codebuild doesnt have a corretto11 with Node14 option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the minimal required node release to 14.x, since Node 12 has
been end-of-life since
2022-04-01. This allows us to upgrade ourTypeScript
targetfromES2019toES2020(native support fornullish-coalescing and optional chaining, among other things).
Removed the
node12entries from the various test matrices and stoppublishing
node12tags forjsii/superchain.BREAKING CHANGE: Beginning with this release, jsii packages no longer
support node 12. Users should migrate to a supported node release (14.x,
16.x, or 18.x).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.