Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.60 causing SyntaxError: Unexpected token '?' #3586

Closed
mccartney opened this issue Jun 9, 2022 · 4 comments
Closed

Regression in 1.60 causing SyntaxError: Unexpected token '?' #3586

mccartney opened this issue Jun 9, 2022 · 4 comments
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@mccartney
Copy link

Describe the bug

After upgrading from 1.59 to 1.60 the Terraform CDK runs end with a failure like below.

Expected Behavior

no failure

Current Behavior

/tmp/jsii-java-runtime946634785065350894/bin/jsii-runtime.js:3666
                this.untested = opts.untested ?? false;
                                               ^
SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47

Reproduction Steps

Sorry, no concise self-contained snippet available. It's buried a few layers in our stack.
In short: Run Terraform CDK.

Possible Solution

No response

Additional Information/Context

No response

SDK version used

1.12.234

Environment details (OS name and version, etc.)

Linux, Docker container based on buildpack-deps:stretch-scm

@mccartney mccartney added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 9, 2022
@mccartney
Copy link
Author

mccartney commented Jun 9, 2022

And now I can see the note in the 1.60 release which probably is relevant here:

Beginning with this release, jsii packages no longer
support node 12. Users should migrate to a supported node release (14.x,
16.x, or 18.x).

i.e. #3547

@mccartney
Copy link
Author

Closing then. It seems like it worked as intented.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@mccartney
Copy link
Author

#3588 is interesting. So maybe Node 12 is somewhat supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant