fix(python): incorrect dependency on jsii #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from `~=<version>` to the correctly translated caret range. Fixes #1573
RomainMuller
added
bug
eladb
approved these changes
Apr 20, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
added a commit
that referenced
this pull request
Apr 20, 2020
The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from `~=<version>` to the correctly translated caret range. Fixes #1573
RomainMuller
added a commit
that referenced
this pull request
Apr 20, 2020
The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from `~=<version>` to the correctly translated caret range. Fixes #1573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from
~=<version>to the correctly translated caret range.Fixes #1573