Skip to content

Commit

Permalink
fix(python): incorrect dependency on jsii
Browse files Browse the repository at this point in the history
The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from `~=<version>` to the correctly translated caret range.

Fixes #1573
  • Loading branch information
RomainMuller committed Apr 20, 2020
1 parent 330ec79 commit 0f63f77
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/lib/targets/python.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ class Package {
packages: modules.map(m => m.pythonName),
package_data: packageData,
python_requires: '>=3.6',
install_requires: [`jsii~=${jsiiVersionSimple}`, 'publication>=0.0.3'].concat(dependencies),
install_requires: [`jsii${toPythonVersionRange(`^${jsiiVersionSimple}`)}`, 'publication>=0.0.3'].concat(dependencies),
classifiers: [
'Intended Audience :: Developers',
'Operating System :: OS Independent',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"python_requires": ">=3.6",
"install_requires": [
"jsii~=0.0.0",
"jsii>=0.0.0, <0.0.1",
"publication>=0.0.3"
],
"classifiers": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"python_requires": ">=3.6",
"install_requires": [
"jsii~=0.0.0",
"jsii>=0.0.0, <0.0.1",
"publication>=0.0.3",
"scope.jsii-calc-base-of-base>=0.0.0, <0.0.1"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"python_requires": ">=3.6",
"install_requires": [
"jsii~=0.0.0",
"jsii>=0.0.0, <0.0.1",
"publication>=0.0.3",
"scope.jsii-calc-base>=0.0.0, <0.0.1",
"scope.jsii-calc-base-of-base>=0.0.0, <0.0.1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"python_requires": ">=3.6",
"install_requires": [
"jsii~=0.0.0",
"jsii>=0.0.0, <0.0.1",
"publication>=0.0.3",
"scope.jsii-calc-base>=0.0.0, <0.0.1",
"scope.jsii-calc-base-of-base>=0.0.0, <0.0.1",
Expand Down

0 comments on commit 0f63f77

Please sign in to comment.