-
Notifications
You must be signed in to change notification settings - Fork 245
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: @jsii/check-node crashes on loading with older node releases
It was built with ES2020 target, which fails to load with Node 10 and 12 as it makes use of the ?? syntax, which is not available in those releases. Changing the TypeScript target so that code continues to load in older node releases.
- Loading branch information
1 parent
de3fc03
commit 839386c
Showing
3 changed files
with
8 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,14 @@ | ||
{ | ||
"extends": "../../../tsconfig-base", | ||
"compilerOptions": { | ||
"target": "es2018", // Needs to target older releases of node or else it'll crash on start when using those | ||
"outDir": "./lib", | ||
"rootDir": "./src", | ||
}, | ||
"include": ["src/**/*.ts"], | ||
"exclude": ["jest.config.ts"], | ||
"include": [ | ||
"src/**/*.ts" | ||
], | ||
"exclude": [ | ||
"jest.config.ts" | ||
], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters