feat(python): add explicit return type to setters (#1645)

Add an explicit `-> None` return annotation to generated property setter methods. This makes the general style more consistent.
aws · May 11, 2020 · 0f3c6e2 · 0f3c6e2
1 parent b4caff7
commit 0f3c6e2
Show file tree

Hide file tree

Showing 6 changed files with 93 additions and 93 deletions.
diff --git a/packages/jsii-pacmak/lib/targets/python.ts b/packages/jsii-pacmak/lib/targets/python.ts
@@ -633,7 +633,7 @@ abstract class BaseProperty implements PythonBase {
       if (renderAbstract && this.abstract) {
         code.line('@abc.abstractmethod');
       }
-      code.openBlock(`def ${this.pythonName}(${this.implicitParameter}, value: ${pythonType})`);
+      code.openBlock(`def ${this.pythonName}(${this.implicitParameter}, value: ${pythonType}) -> None`);
       if ((this.shouldEmitBody || forceEmitBody) && (!renderAbstract || !this.abstract)) {
         code.line(`jsii.${this.jsiiSetMethod}(${this.implicitParameter}, "${this.jsName}", value)`);
       } else {