Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sigv4-proxy-admission-controller] Adding Mechanism to Avoid Deadlock #823

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wjhhuizi
Copy link

@wjhhuizi wjhhuizi commented Sep 13, 2022

Issue

#822 Avoiding Deadlock in aws-sigv4-proxy-admission-controller Chart.

Description of changes

Adding an objectSelector to avoid webhook lock it self out in case of crashing or evicting situation.
This will allow webhook to skip applying mutation webhhok on pods with lable app: {{ template "aws-sigv4-proxy-admission-controller.fullname" . }}

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Manually deployed modified Chart and the pod can now avoid locking itself out after crashing/evicting/scaling event.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adding an objectSelector to avoid webhook lock it self out in case of crashing or evicting situation. 
This will allow webhook to skip applying mutation webhhok on pods with lable `app: {{ template "aws-sigv4-proxy-admission-controller.fullname" . }}`
Update Chart.yaml from 0.1.2 -> 0.1.3
@wjhhuizi wjhhuizi marked this pull request as ready for review September 13, 2022 02:17
@wjhhuizi wjhhuizi changed the title Adding Mechanism to Avoid Deadlock [aws-sigv4-proxy-admission-controller] Adding Mechanism to Avoid Deadlock Sep 13, 2022
@butlern
Copy link

butlern commented Oct 18, 2022

I just ran into this issue when creating the sigv4 deployment with this chart. It was installing the webhook config before the deployment and the deployment was failing to launch due to needing to hit the webhook admission endpoint which was managed by the deployment... Would be great to see this merged. 👍

@guitmz
Copy link

guitmz commented Sep 11, 2023

this is still happening after 1 year...

edit: the fix is not working for me 100% though. It does make the pod able to restart but I still see the consequences of #672 on any new pod that tries to start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants