[aws-for-fluent-bit] User should be able to provide an existing fluent-bit configmap #743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
We are migrating from fluent-bit installation made based on EKS deployment guide. This article creates a set of custom fluent-bit configs which are not easy to migrate considering how fluent-bit populated now. I believe that a user should be able to provide own configmap with custom configurations.
Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
helm upgrade --install aws-for-fluent-bit ./
- creates a managed cm and mounts the cmhelm upgrade --install aws-for-fluent-bit --set existingConfigMapName=my-custom-cm ./
- mounts an existing cmBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.