Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-for-fluent-bit] Replaced docker.io image repo by public ECR #732

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

mickeypash
Copy link
Contributor

It would make sense that all EKS charts now use the ECR Public
repository. [re #356]

Issue

Description of changes

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

  • Tested on an internal k8s cluster.
helm upgrade --install aws-for-fluent-bit eks/aws-for-fluent-bit 
    -n kube-system \
    -f helm/fluent-bit.yml \
    --debug \

Way of checking which image is being used

kubectl get pods -l app.kubernetes.io/name=aws-for-fluent-bit \
-n kube-system -o jsonpath="{.items[].spec.containers[].image}" \
 | tr -s '[[:space:]]' '\n' \
 | sort \
 | uniq -c

1 public.ecr.aws/aws-observability/aws-for-fluent-bit:2.21.5

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It would make sense that all EKS charts now use the ECR Public
repository. [re aws#356]
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @mickeypash!

@jaypipes jaypipes merged commit d96970c into aws:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants