[aws-for-fluent-bit] Add serviceAccount.annotations
parameter to README
#622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#395
Description of changes
Updated README.md with the following changes:
serviceAccount.create
parameter from the Configuration sectionserviceAccount.annotations
parameter to the Configuration section to reflect the availability of this, ref. https://github.com/aws/eks-charts/blob/master/stable/aws-for-fluent-bit/templates/serviceaccount.yaml#L9-L12Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
This functionality already exists, so I verified that it works with:
And then:
$ kubectl get serviceaccount aws-for-fluent-bit -n kube-system -o yaml | head -n5 apiVersion: v1 kind: ServiceAccount metadata: annotations: eks.amazonaws.com/role-arn: dummy-role-arn
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.