Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-vpc-cni] Update to v1.6.3 #206

Merged
merged 2 commits into from
Jul 18, 2020
Merged

[aws-vpc-cni] Update to v1.6.3 #206

merged 2 commits into from
Jul 18, 2020

Conversation

max-rocket-internet
Copy link
Contributor

Please merge #205 first so that version v1.6.2 is not skipped.

As far as I can see there's no other required changes apart from the image tag: https://github.com/aws/amazon-vpc-cni-k8s/commits/master/config/v1.6/aws-k8s-cni.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@max-rocket-internet
Copy link
Contributor Author

Please review @jaypipes 🙂

@jaypipes
Copy link
Contributor

We need to do a release/git tag for the 1.6.2 change (which will trigger a chart release/publish). I'll do that today (we've got a pile of merges to aggregate into a repo release) and then merge this and do another git tag.

@max-rocket-internet
Copy link
Contributor Author

We need to do a release/git tag for the 1.6.2 change (which will trigger a chart release/publish)

I think I've asked this before but why not just have that CI process triggered on every merge to master? Then you don't need to remember to create a release and everyone can access the new chart versions after the PR is merged 🙂

@TBBle
Copy link

TBBle commented Jul 13, 2020

@max-rocket-internet Per aws/amazon-vpc-cni-k8s#758 (comment) that will be happening in https://github.com/aws/amazon-vpc-cni-k8s when the true-source of the amazon-vpc-cni Helm chart moves there.

@max-rocket-internet
Copy link
Contributor Author

@jaypipes can we get that release and then merge this PR and then another tag? We're waiting on version 1.6.3 to fix CNI pod restarts.

@max-rocket-internet
Copy link
Contributor Author

@jaypipes can we merge?

Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@mogren mogren merged commit 02e0114 into aws:master Jul 18, 2020
@max-rocket-internet max-rocket-internet deleted the CNI_1.6.3 branch July 20, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants