Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway CRDs to appmesh-controller #190

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Add gateway CRDs to appmesh-controller #190

merged 2 commits into from
Jul 10, 2020

Conversation

fawadkhaliq
Copy link

@fawadkhaliq fawadkhaliq commented Jun 30, 2020

Description of changes:

  • Add virtual gateway and gateway routes CRDs to appmesh-controller
  • Add support for access log per virtual gateway. See the API changes here. Updated appmesh-gateway to reflect the change
  • Bump the controller version to v1.1.0

Logging will be directly under virtual gateway moving forward. Here's a sample spec

apiVersion: appmesh.k8s.aws/v1beta2
kind: VirtualGateway
metadata:
  name: vg1
  namespace: ns1
spec:
  namespaceSelector:
    matchLabels:
      gateway: vg1
  podSelector:
    matchLabels:
      app: vg1
  listeners:
    - portMapping:
        port: 8088
        protocol: http
  logging:
    accessLog:
      file:
        path: /dev/stdout

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fawadkhaliq fawadkhaliq self-assigned this Jun 30, 2020
@fawadkhaliq fawadkhaliq marked this pull request as draft June 30, 2020 16:46
@fawadkhaliq
Copy link
Author

Marking this as draft until we have a new controller image

Copy link
Collaborator

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fawadkhaliq fawadkhaliq marked this pull request as ready for review July 10, 2020 01:08
@fawadkhaliq fawadkhaliq merged commit be8f3fa into aws:master Jul 10, 2020
@fawadkhaliq fawadkhaliq deleted the vg branch July 10, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants