Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Calico Chart - seems missing permission for typha-cpha #108

Closed
JakubSmejkal opened this issue Apr 16, 2020 · 3 comments
Closed

AWS Calico Chart - seems missing permission for typha-cpha #108

JakubSmejkal opened this issue Apr 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JakubSmejkal
Copy link

JakubSmejkal commented Apr 16, 2020

typha autoscaler logs:
E0416 03:30:41.156961 1 reflector.go:283] github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to watch *v1.Node: unknown (get nodes) │
│ E0416 03:30:42.163238 1 reflector.go:283] github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to watch *v1.Node: unknown (get nodes) │
│ E0416 03:30:43.170184 1 reflector.go:283] github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to watch *v1.Node: unknown (get nodes) │
│ I0416 03:30:44.157683 1 k8sclient.go:221] Falling back to extensions/v1beta1, error using apps/v1: deployments.apps "calico-typha" is forbidden: User "system:serviceaccount:kube-system:calico-ty │
│ pha-cpha" cannot get resource "deployments/scale" in API group "apps" in the namespace "kube-system" │
│ E0416 03:30:44.463196 1 reflector.go:283] github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to watch *v1.Node: unknown (get nodes) │
│ E0416 03:30:45.563406 1 reflector.go:283] github.com/kube

it looks like there is missing permission in typha-cpha Rola and ClusterRole:

--- a/stable/aws-calico/templates/rbac.yaml
+++ b/stable/aws-calico/templates/rbac.yaml
ClusterRole:
resources: ["nodes"]
old verbs: ["list"]
new verbs: ["watch", "list"]


Role:
old - apiGroups: ["extensions"]
new - apiGroups: ["extensions", "apps"]
resources: ["deployments/scale"]
verbs: ["get", "update"]

@mogren mogren added bug Something isn't working good first issue Good for newcomers labels Apr 16, 2020
@mogren
Copy link
Contributor

mogren commented Apr 16, 2020

You are right about this. See aws/amazon-vpc-cni-k8s#892 for some more details.

@jaypipes
Copy link
Contributor

Yet another reason we need to have a single source of config truth :)

@haouc
Copy link
Contributor

haouc commented Nov 24, 2021

Since this has been updated and fixed, I am closing this issue.

@haouc haouc closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants