Use bmclib directly: #6851
Merged
Use bmclib directly: #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through Rufio just for the bmclib client means that we had to take on Rufio's dependencies. This is problematic because Rufio uses the controller-runtime lib. Using bmclib directly alleviates us from this concern. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
eks-distro-bot
added
the
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobweinstock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This avoids having to pull in Rufio as a dependency. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
eks-distro-bot
added
size/XL
New version of logr.Logger broken some tests. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6851 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 532 532
Lines 41640 41641 +1
=======================================
+ Hits 29987 29988 +1
Misses 9980 9980
Partials 1673 1673 ☔ View full report in Codecov by Sentry. |
ahreehong
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Going through Rufio just for the bmclib client means that we had to take on Rufio's dependencies. This is problematic because Rufio uses the controller-runtime lib. Using bmclib directly alleviates us from this concern.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.