Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1-29 release branch support #2693

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add 1-29 release branch support #2693

merged 1 commit into from
Nov 30, 2023

Conversation

abhay-krishna
Copy link
Member

This PR adds EKS-D 1-29 release branch support to the build-tooling projects.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2023
@abhay-krishna abhay-krishna force-pushed the 1-29-support branch 2 times, most recently from c8cd5af to 9d695da Compare November 30, 2023 09:28
@abhay-krishna abhay-krishna marked this pull request as ready for review November 30, 2023 09:28
@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
@abhay-krishna
Copy link
Member Author

/test autoscaler-1-29-presubmit

@abhay-krishna
Copy link
Member Author

/test cloud-provider-vsphere-1-29-tooling-presubmit
/test cloud-provider-aws-1-29-tooling-presubmit

@abhay-krishna
Copy link
Member Author

/test imagebuilder-1-29-presubmit
/test kind-1-29-presubmit

@abhay-krishna
Copy link
Member Author

/test kind-1-29-tooling-presubmit

@abhay-krishna abhay-krishna force-pushed the 1-29-support branch 3 times, most recently from 602aeab to c33e328 Compare November 30, 2023 21:09
@abhay-krishna abhay-krishna changed the title WIP: Add 1-29 release branch support Add 1-29 release branch support Nov 30, 2023
jaxesn
jaxesn reviewed Nov 30, 2023
View reviewed changes
projects/kubernetes-sigs/image-builder/Makefile
@@ -67,6 +67,7 @@ ADDITIONAL_PAUSE_1-25_FROM=1-24
ADDITIONAL_PAUSE_1-26_FROM=1-26
ADDITIONAL_PAUSE_1-27_FROM=1-27
ADDITIONAL_PAUSE_1-28_FROM=1-28
ADDITIONAL_PAUSE_1-29_FROM=1-28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify this based on the above rules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes 1.29 had pause version 3.9 in the constants.go, and both 1.28 and 1.29 had 3.9 as the pause version in the Makefile. So I guess 1-28 should also work? But I can change it to 1-29.

jaxesn
jaxesn reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@jaxesn jaxesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, just double check that pause image thing.

@abhay-krishna abhay-krishna force-pushed the 1-29-support branch 6 times, most recently from d9f4e50 to 65593f1 Compare November 30, 2023 22:45
@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 91ce512 into aws:main Nov 30, 2023
@abhay-krishna abhay-krishna deleted the 1-29-support branch March 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxesn jaxesn jaxesn approved these changes

Assignees

@jaxesn jaxesn

Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhay-krishna @eks-distro-bot @jaxesn